iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

Makefile - Make it a bit more usable #701

Closed omesser closed 1 year ago

omesser commented 1 year ago
omesser commented 1 year ago

Why does the leo binary have a GO{OS,ARCH} suffix? 🤔 I'd assume that local developers won't do that much cross-compilation.

@0x2b3bfa0 Just a good practice IMO to make those explicit - always set up things with cross-compilation in mind, at some point someone will test different GOOS/GOARCH and binaries will override and it will be annoying, and no real downsides (it's a suffix, tab-completion removes terminal-unweildliness).

So - just personal preference / practice. If you (or anyone) find this detrimental I'll just remove 😄

0x2b3bfa0 commented 1 year ago

[...] at some point someone will test different GOOS/GOARCH [..] If you (or anyone) find this detrimental I'll just remove

This is too subjective to unbury my “detrimental sledgehammer” but I can't imagine any plausible case where cross-compiling this project during local development would become a commonplace practice. 🤷🏼‍♂️