Fix slow list Performance when bucket is empty

iternity-dotcom / minio

High Performance, Kubernetes Native Object Storage

https://min.io/download

GNU Affero General Public License v3.0

6 stars 1 forks source link

Fix slow list Performance when bucket is empty #7

Closed rafikc30 closed 2 years ago

rafikc30 commented 3 years ago

Description

Motivation and Context

How to test this PR?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (provides speedup with no functional changes)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Fixes a regression (If yes, please add commit-id or PR # here)
[ ] Documentation updated
[ ] Unit tests added/updated

rluetzner commented 3 years ago

@rafikc30, please talk to @aweisser how we're going to handle changes on this fork. AFAIK the master branch here should be mostly up to date with the official master branch. I'm not entirely sure what the best way to handle our diverging code is.

iternity-dotcom commented 3 years ago

@rluetzner I think this change should also be considered to be part of our "performance PR". And maybe also something that we can bring upstream. Can you please take a look at it!?

rluetzner commented 3 years ago

@rafikc30 , can you select the 'iternity' branch as the target? This will trigger the GitHub CI and give us some feedback on tests. We do have at least one flaky test currently, so don't be surprised if the CI complains. 😉

rluetzner commented 2 years ago

AFAIK all of these changes made it into the iternity-rb branch one way or another. Most of the issues were already addressed by MinIO's upstream.