search

itesla / ipsl

The iTesla Power System Library is a Modelica library developed as part of the iTesla project. The library contains a set of power system component models for phasor time domain simulations.
Mozilla Public License 2.0
23 stars 71 forks source link

Move copyright notice into "revisions" section? #62

Closed dietmarw closed 8 years ago

dietmarw commented 8 years ago

I noticed that you have the copyright notice present in all models in the "info" layer of the documentation. You might consider using the "revisions" layer instead for this purpose. This way it's easier to distinguish between real info and just default copyright and authors stamp. Quite a lot libraries do it this way but is of course not a must.

A step further would be to not have the copyright notice in all models in the development version but a simple place holder (e.g., <!-- DISCLAIMER --> which is legal HTML and will not cause HTML checker to complain :-) ) that gets replaced with an updated copyright notice before release. That way your source code does not have lots of duplicate code that needs to be updated with every release. Just an idea.

MaximeBaudette commented 8 years ago

For your first comment: Yes why not, my first try was to put the copyright notice in the Modelica code as a comment, but this turned out to not work as expected. Then I thought about the information annotations, and nobody had objections, so we went for it.

For your second comment: I see your point, but I guess it is a bit too fancy for now. We already have a hard time keeping up with other issues of the library.

MaximeBaudette commented 8 years ago

@dietmarw that closing was involuntary, I clicked the wrong button.

MaximeBaudette commented 8 years ago

Following the discussion in #7 , the license will be changed to MPL 2 if I'm not mistaken. When I update the license I will put it in the "revision" section