N44. Model SCRX - Githubissues

itesla / ipsl

The iTesla Power System Library is a Modelica library developed as part of the iTesla project. The library contains a set of power system component models for phasor time domain simulations.

Mozilla Public License 2.0

23 stars 71 forks source link

N44. Model SCRX #89

Closed AIAitesla closed 8 years ago

AIAitesla commented 8 years ago

@tinrabuzin In Modelica model iPSL.Electrical.Controls.PSSE.ES.SCRX.SCRX the parameter C_SWITCH is declared as a boolean while in PSS/E this parameter can take values 0.0 or 1.0 (double value).

We can cast this value from double to boolean in the conversion. But it would be better to have the same type of parameter in Modelica an PSS/E because an external user will not have access to the conversion code.

Please, can you change this parameter in the model?

tinrabuzin commented 8 years ago

It won't be exactly the elegant solution to change this. It'll just unnecessary complicate the model.

I'm afraid I don't understand what does access to conversion code have to do with casting parameters. If it's absolute must, then I'll do it.

AIAitesla commented 8 years ago

Ok. We will do the cast from double to boolean in the converter. The only thing to keep in mind is that the user will see:

In PSS/E a double parameter value.
In Modelica a boolean parameter value.

tinrabuzin commented 8 years ago

@AIAitesla The name is pretty self-explanatory (SWITCH) so I think it'll be fine. Thanks!