itflow-org / itflow

Free and open-source web application for MSPs. Unifies IT documentation, ticketing, invoicing.
https://itflow.org
GNU General Public License v3.0
590 stars 152 forks source link

cron_ticket_email_parser.php - send new ticket opened email to unknown clients #1076

Closed cybershieldms closed 2 months ago

cybershieldms commented 2 months ago
wrongecho commented 2 months ago

Test these changes at: https://ticketfeatures1076.pr-review.itflow.org
(automatic message)

wrongecho commented 2 months ago

Hey @cybershieldms

Thanks for the PR! :)

I've tested and this seems to work nicely. I like the way you've put the persons name in bold and email in brackets too!

image

Great concept with excluding bounces but I'd suggest we exclude admin/reply as these can often be used legitimately/for messages you want.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cybershieldms commented 2 months ago

Great concept with excluding bounces but I'd suggest we exclude admin/reply as these can often be used legitimately/for messages you want.

@wrongecho - Thanks! First time with Github. Done... Changed the regex to just include postmaster and daemon.

In the future, I could see a configurable variable in Settings to make a customizable block list.

johnnyq commented 2 months ago

@cybershieldms looks good Great first commit @wrongecho I think everything looks good, I approve the merge just wanted to get any last minute thoughts

wrongecho commented 2 months ago

@wrongecho - Thanks! First time with Github. Done... Changed the regex to just include postmaster and daemon.

In the future, I could see a configurable variable in Settings to make a customizable block list.

You've done great for your first time!! :)

Agreed, it would be nice to make the ignore list configurable.

johnnyq commented 2 months ago

awesome, we'll pull this one in

wrongecho commented 2 months ago

Nice work Craig!! :)