Closed cybershieldms closed 2 months ago
Test these changes at: https://ticketfeatures1076.pr-review.itflow.org
(automatic message)
Hey @cybershieldms
Thanks for the PR! :)
I've tested and this seems to work nicely. I like the way you've put the persons name in bold and email in brackets too!
Great concept with excluding bounces but I'd suggest we exclude admin/reply as these can often be used legitimately/for messages you want.
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Great concept with excluding bounces but I'd suggest we exclude admin/reply as these can often be used legitimately/for messages you want.
@wrongecho - Thanks! First time with Github. Done... Changed the regex to just include postmaster and daemon.
In the future, I could see a configurable variable in Settings to make a customizable block list.
@cybershieldms looks good Great first commit @wrongecho I think everything looks good, I approve the merge just wanted to get any last minute thoughts
@wrongecho - Thanks! First time with Github. Done... Changed the regex to just include postmaster and daemon.
In the future, I could see a configurable variable in Settings to make a customizable block list.
You've done great for your first time!! :)
Agreed, it would be nice to make the ignore list configurable.
awesome, we'll pull this one in
Nice work Craig!! :)