search

itflow-org / itflow

Free and open-source web application for MSPs. Unifies IT documentation, ticketing, invoicing.
https://itflow.org
GNU General Public License v3.0
562 stars 145 forks source link

OTP not working properly #202

Closed cproudlock closed 2 years ago

cproudlock commented 2 years ago

OTP doesn't appear to be working. Generated codes are not correct.

aftechro commented 2 years ago

hey @Somesite

there`s still much to do on the OTP aspect.

@johnnyq is having a lot on his plate, but with patience, everything will be ready at one stage with future updates.

just keep an eye on this

johnnyq commented 2 years ago

@Somesite, @aftechro is right I have been really busy managing our business and it has gotten quite busy. This is something I would really like to accomplish as 2FA OTP (HOTP / TOTP) is huge these days. I have been mostly relying on Bitwarden for this job at the moment. Stay tuned.

johnnyq commented 2 years ago

@Somesite @aftechro this should be fixed please test and let me know see fix 53380718b141072f532746135abffc5627978801

aftechro commented 2 years ago

Great to see that Johnny, and much appreciate it.

just to make sure this is right, will the OTP generate multiple codes as below or should just generate and match the code as per other otp app?

image

for instance, i get same code if i`m using app on the phone or extension in the browser on pc.

Also, forgot to mention in the past, the password field in the logins section is visible by default and the hide/unhide icon, not working. But works fine in other sections.

johnnyq commented 2 years ago

Hi @aftechro There is still something still wrong with the code. I think it may be related to the way my app is handling timezones. I need to continue figuring this out. It ended up being much more complex than I have imagined.

I will work on the a fix for the password reveal in listing.

johnnyq commented 2 years ago

I fixed the password reveal ended up using a popover for the big reveal worked like a charm

85cdc42d0f15e36de5cab00d7f3c799a056e85ef

aftechro commented 2 years ago

Hey Johnny,

That's great, much appreciated!

Thank you!

Wikiphil commented 2 years ago

Hello, OTP is working and follow the beat! But, why 7 codes appear? I understand the code in the middle of all is the one to use.

Keep your good work! :-)

Regards.

wrongecho commented 2 years ago

I've adjusted this to only show one code at a time.

image