Add timers modal to see all timers

[o-psi]

Added a modal to the topnav to see your total timers as suggested here: https://forum.itflow.org/d/506-new-time-tracking-ui-timer-edits-are-overwrittenreset/5

[wrongecho]

Test these changes at: https://SeeAllTimers803.pr-review.itflow.org
(automatic message)

[o-psi]

@johnnyq this is ready to pull

[johnnyq]

@o-psi There are a few links that callback to your dev platform, please clean these up before merge

 ticketDiv.innerHTML = `
                    <div class="card-header">
                        <h3 class="card-title">Ticket ID: ${ticketID}</h3>
                        <a href="https://develop.twe.tech/ticket.php?ticket_id=${ticketID}" class="btn btn-primary float-right">View Ticket</a>

[o-psi]

@johnnyq this has been done. Nice catch.

[wrongecho]

• Timer should not display when ticketing module is disabled

• Closing a ticket does not clear it from the active timers (and once the ticket is closed there is seemingly no easy way to remove this timer at all now)

• More general but from a user experience perspective, using the ticket ID in the header is a little confusing. If you re-number the tickets then the database ID here is technically 3 but the ticket ref is TCK-4081 - the view ticket button works as expected though

• Again more general, but if there are no timers active then the red notification count should disappear (the way notifications do)

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[o-psi]

@johnnyq @wrongecho This should be ready

[johnnyq]

Hi @o-psi Im looking over the code changes and may have missed it but some of the issues @wrongecho pointed out don't seem to be resolved just yet

• Don't display ticket id but ticket number:
• Don't Show Timer if Ticketing module is disabled
• and if the ticket gets closed clear the timer for that ticket

[o-psi]

@johnnyq all but the first is resolved. I am still trying to think of a good way to get the ticket number out of the ID via JavaScript.

The timer in the header is wrapped in an if, and it's working on my dev environment, so not sure what you know that I don't.

Ticket time does get cleared after close. There is an event listener on the ticket_timer.js file that clears any storage. There is also now a clear all button in the modal to clear stuck or old timers.

[o-psi]

Regardless, this exponentially increases the usability of the timers... This is a beta app, correct?

If we are waiting for the feature to be complete, why is there a remember me checkbox on the login screen?

[johnnyq]

good point, ill get this finished sometime today and yes it is a beta app, but were trying to hit stable come New Years, just as long as it gets fixed before then. We have so much that needs to get fixed before then. I want to eventually put a feature freeze on ITFlow by the end of November and then just muscle out all the bugs in December.

[johnnyq]

and beside that I cant make the DB changes I need for remember me because you made DB changes that need merged before I can make DB Changes, but still need reviewed.

[johnnyq]

Okay im gonna reel this one in

[o-psi]

and beside that I cant make the DB changes I need for remember me because you made DB changes that need merged before I can make DB Changes, but still need reviewed.

@johnnyq I can always redo my DB Update in a PR. Dont let a PR with a DB update get in the way of making this program the best it can be!