itflow-org / itflow

Free and open-source web application for MSPs. Unifies IT documentation, ticketing, invoicing.
https://itflow.org
GNU General Public License v3.0
568 stars 147 forks source link

Bugfix: Quote/Invoice quantity 4 digits #851

Closed wrongecho closed 10 months ago

wrongecho commented 10 months ago

Perform quote/invoice quantity number formatting after invoice sub-total is calculated to prevent math issues due to comma added for thousands

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
6.7% Duplication on New Code

See analysis details on SonarCloud

wrongecho commented 10 months ago

Test these changes at: https://bugfixinvquoquantitymath851.pr-review.itflow.org
(automatic message)

wrongecho commented 10 months ago

Reported: https://forum.itflow.org/d/635-invoice-locked-when-having-a-quantity-with-4-characters/5

Tested on PR Review. Confirmed fixed - merging.