Closed o-psi closed 7 months ago
Test these changes at: https://scheduledtickets867.pr-review.itflow.org
(automatic message)
@o-psi We currently already have scheduled tickets (Im sure you already know that), is this different than that or set to replace or merge with it by integrating into one table called tickets?
The current 'scheduled tickets' is better described as 'reoccurring tickets'.
Rather, this is for when a ticket exists, but the work for it is scheduled sometime in the future.
I see now, technically scheduled tickets is named improperly due to its function.
So heres a thought what about using scheculed tickets tables and views/edit/create but being able to select Just once under frequency, Im open to your opinions and suggestions on this one
Originally, that is how i thought it would work best aswell, and maybe we can add a link there. But I think we need to rename scheduled tickets to recurring tickets, then it will no longer make sense to have this feature under a Once option. Things do not reoccur once...
Maybe I can spend some time in the docs explaining it.
hmmm im almost wondering about merging scheduled (aka recurring tickets into the tickets table and just make it one entity with flags indicating recurring, scheduled or regular ticket.
What's being proposed here and the existing scheduled/recurring tickets are entirely separate in my view. This is about scheduling a future time to work on a ticket.
I'd support renaming scheduled tickets to recurring, but perhaps this function should be part of the Pending/On Hold flow instead? Tickets would automatically be moved back to an open / working state once the scheduled time arrives. Ideal for planned site visits, new starters, OOH work, etc.
Wrong Echo, perfectly stated.
I support adding a link on the pending to open this modal when set to pending aswell.
Im gonna get to work on the proposed changes tomorrow.
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
How do we want to include this into the pending or onhold flow?
Lets hold off on the pending and on-hold flow for right now and play around with what you got I reviewed the code Its ready to be reeled in except for the Database changes need to be updated as we recently added AI items to the DB. Along with new DB Dump db.sql for new installs
This pull request includes the following changes:
Added a new column
ticket_schedule
to thetickets
table.Added a new modal
editTicketScheduleModal
for editing the scheduled time of a ticket.Displayed the scheduled time of a ticket in the ticket details section.
Added a link to edit the scheduled time in the ticket details section.
Added the tickets to the calendar in the future.
This is seen to be used with appointments in the future, hopefully linking to an external calendar. TODO: Send an ical email to add the event to outlook calendars, or sync calendars another way.