itflow-org / itflow

Free and open-source web application for MSPs. Unifies IT documentation, ticketing, invoicing.
https://itflow.org
GNU General Public License v3.0
544 stars 141 forks source link

0.1.8.2 (Scheduled tickets, and Email Improvements) #875

Closed o-psi closed 7 months ago

o-psi commented 7 months ago

This is the most up to date version of the scheduled tickets change. Added iCal Functionality via The Zap Cal PHP Library

wrongecho commented 7 months ago

Test these changes at: https://0182875.pr-review.itflow.org
(automatic message)

johnnyq commented 7 months ago

Wow that ical support looks super exciting, I have been wanting something like that, Im gonna review then we'll pull it in

johnnyq commented 7 months ago

@o-psi For the iCal functionality I don't think we need to store it in the DB as a separate field It should just send as an attachment, correct?

o-psi commented 7 months ago

I was debating this, but I want the iCal to also show in the mail queue as well eventually, and I don't see that happening easily on the fly any other way.

o-psi commented 7 months ago

Also, If the ticket gets rescheduled, a new email needs to be sent to replace the old ICS, this would best be done by comparing when that field changes.

johnnyq commented 7 months ago

gotchya that makes sense to me

o-psi commented 7 months ago

I am going to work on this a bit more. The emails need some help, and there should be a note in the ticket when scheduled.

johnnyq commented 7 months ago

okay sounds good its looking great so far

o-psi commented 7 months ago

@johnnyq I think this is ready to go

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
21 New issues

Measures
0 Security Hotspots
No data about Coverage
9.3% Duplication on New Code

See analysis details on SonarCloud

johnnyq commented 7 months ago

looks good, im, reeling in

o-psi commented 7 months ago

@johnnyq I would love to write some docs on how this functionality works, yet it seems I do not have perms to create new pages on docs.itflow.com