search

itflow-org / itflow

Free and open-source web application for MSPs. Unifies IT documentation, ticketing, invoicing.
https://itflow.org
GNU General Public License v3.0
535 stars 139 forks source link

Credits and Inventory #905

Closed o-psi closed 5 months ago

o-psi commented 5 months ago

Credits, and Inventory modules.

wrongecho commented 5 months ago

Test these changes at: https://0185905.pr-review.itflow.org
(automatic message)

wrongecho commented 5 months ago

Unsure why #897 was closed, but would recommend credits and inventory are raised as separate PRs to allow for proper testing.

johnnyq commented 5 months ago

This is fine for now just for the future one PR per feature will make it easier to manage and review. I see this is still is draft so will review when ready, looking forward to credits and Inventory.

johnnyq commented 5 months ago

This looks pretty good to me, @o-psi has it been working good for you guys over there @wrongecho how does it look to you

wrongecho commented 5 months ago

On initial review, I'm unable to get the PR Review database past 1.1.0.

wrongecho commented 5 months ago

@johnnyq Have added a few comments but on mobile atm. Will try and take a look this week once the update queries are working.

o-psi commented 5 months ago

@johnnyq When you invited me to fork the repository, that is when we started doing version numbers. And it is the fact that I am doing one PR per version number, rather than feature. This is as, everything from 0.1.8.4 would have been in this PR regardless.

o-psi commented 5 months ago

I cannot mark the changes as accepted, but all comments have been resolved. We have now been using for a few days, and have yet to find any quirks.

johnnyq commented 5 months ago

Something still appears to broken on Database updates.

o-psi commented 5 months ago

There seems to be a few commits missing that must be stashed somewhere. I know I went through and sanitized most if not all of these mentioned. Many thanks for taking the time to recognize that.

johnnyq commented 5 months ago

Hey @o-psi the field names should be singular for the table inventory_locations to keep consistency example inventory_location_id

o-psi commented 5 months ago

Crazy weekend. This has been fixed.

johnnyq commented 5 months ago

Crazy weekend. This has been fixed.

Yeah man same here We'll go ahead and review further

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
62 New issues
0 Accepted issues

Measures
1 Security Hotspot
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud