itgalaxy / favicons

Favicons generator for Node.js
MIT License
1.19k stars 164 forks source link

Always generate manifest.json? #202

Open brunocodutra opened 6 years ago

brunocodutra commented 6 years ago

Now that browsers other than chrome are picking up on support for manifest.json does it make sense to have it always generated?

alexander-akait commented 6 years ago

@brunocodutra better add option (by default in true) :+1:

musaffa commented 6 years ago

I had to remove this package once I realized that it is also generating manifest.json and there is no way to disable it. I'm using another package for manifest management. I wish this package solely focused on favicons.

alexander-akait commented 6 years ago

@musaffa we will have option for disable this :+1:

musaffa commented 5 years ago

@evilebottnawi Is there any update about having an option to disable manifest generation?

oller commented 5 years ago

It seems manifest.json can support a lot of properties that aren't supported by favicons, i.e. related_applications, prefer_related_applications: etc.

Which as mentioned above is forcing users to use another package to handle the manifest generation, the loss being you're going to have to handle icons separately again.

If either this plugin could have a flag to disable manifest, or ideally take an options.seed object which it dumps into the manifest allowing support for all/any future manifest properties?

slayerpart commented 4 years ago

@evilebottnawi Any status update about optional manifest generation? This is really blocking us from using this module.

alexander-akait commented 4 years ago

@slayerpart PR welcome

johndeighan commented 1 year ago

It appears that in the latest version, the manifest file's name has been changed. Maybe it's in response to the above complaints, but to me, it totally makes sense that this package generates a manifest file since a large part of the manifest file is the list of icons. I found it particularly annoying that the file extension was changed because now when I view the file in my editor, I don't get syntax lighting.

Luckily, I found a workaround that might also work for the above issues. It seems to be totally undocumented, but if in your config object you add the key files.android.manifestFileName and set it to the name you want the file to have, the resulting manifest file will have that name. Of course, that name is also used in the generated index.html file (which you can also rename).

For the maintainers, on the README page, there are comments that refer to the 'manifest.json' file, even though by default it's not named that. It might confuse some people (like me ;-)

andy128k commented 1 year ago

@johndeighan See #368