Allow to rename files (manifests)

itgalaxy / favicons

Favicons generator for Node.js

MIT License

1.19k stars 164 forks source link

Allow to rename files (manifests) #361

Closed andy128k closed 2 years ago

andy128k commented 2 years ago

Addresses #354 and #280.

This change looks big, but actually functions which generate manifests/configs were just moved inside corresponding platform classes.

andy128k commented 2 years ago

There is a drawback in this approach (at least one, he-he). Someone may try to change a path of a manifest file to another directory. But this will not work and icons will not be loaded.

alexander-akait commented 2 years ago

Feel free to close resolved issues