search

itgalaxy / nunjucks-webpack-plugin

A webpack plugin for nunjucks.
MIT License
27 stars 12 forks source link

Webpack v5 support #21

Open burt202 opened 3 years ago

burt202 commented 3 years ago

Hi,

It'll be good for this plugin to support webpack v5. In the meantime Ive forked/rewritten it here https://github.com/burt202/nunjucks-webpack-plugin for anyone that wants v5 support sooner. It also simplifies the code and massively reduces (and updates) all dependencies

Cheers

Jakobud commented 2 years ago

@alexander-akait would it be possible to incorporate these improvements into this repo so that Webpack 5 is supported? Or would it be possible to pass the ownership/responsibility of this repository to someone who could update it and publish to NPM?

alexander-akait commented 2 years ago

Sorry, I don't have time on this package, I can give permissions for this repo and npm

burt202 commented 2 years ago

Im happy to take this on if you like. Let me know what I need to do

alexander-akait commented 2 years ago

sent invite

burt202 commented 2 years ago

Ok cool, i wont do anything immediately but I'll likely just override the whole repo with the code in the fork and then publish a v6. Ill keep the license and changelog bits though.

Also its worth noting, my fork doesnt port across all features, so I would be tempted to fix forward and see what people miss as time goes on.

How does that sound? Everyone happy with that?

alexander-akait commented 2 years ago

Yep, feel free to send PRs, I will review

burt202 commented 2 years ago

Ive just brought over the tests into my fork and one of them fails due to changes with webpack between v4 and v5 (to do with compilation.hash). I havent got time right now to look into this Im afraid but hopefully I can find some time soon to complete this update