search

itgalaxy / nunjucks-webpack-plugin

A webpack plugin for nunjucks.
MIT License
27 stars 12 forks source link

Webpack 4 support #9

Closed burt202 closed 6 years ago

burt202 commented 6 years ago

This seems to fix it for me. Let me know what you think

alexander-akait commented 6 years ago

@burt202 better get logic from https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/src/index.js#L117 to allow run plugin on webpack@3 and webpack@4

burt202 commented 6 years ago

Extended the PR based on your comment.

alexander-akait commented 6 years ago

@burt202 run prettier on code for tests

alexander-akait commented 6 years ago 
[lint:eslint  ] /home/travis/build/itgalaxy/nunjucks-webpack-plugin/src/NunjucksWebpackPlugin.js
[lint:eslint  ]   106:32  error  'file' is defined but never used. Allowed unused args must match /^_/        no-unused-vars
[lint:eslint  ]   107:13  error  Variable 'compilationFileDependencies' should be initialized on declaration  init-declarations
[lint:eslint  ]   108:13  error  Variable 'addFileDependency' should be initialized on declaration            init-declarations
[lint:eslint  ]   112:31  error  'file' is already declared in the upper scope                                no-shadow
[lint:eslint  ]   115:31  error  'file' is already declared in the upper scope                                no-shadow
[lint:eslint  ]   118:20  error  'file' is already declared in the upper scope                                no-shadow
[lint:eslint  ]   118:20  error  'file' is already declared in the upper scope                                no-shadow

from CI, need fix

burt202 commented 6 years ago

Thanks just saw this in travis, im on it.

alexander-akait commented 6 years ago

@burt202 thanks :+1: