Closed Celerium closed 11 months ago
With all the new development going on when would be a good time to merge these changes? I was thinking once #157 is completed.
This would give me or others time to review any grammar or consistency issues with help descriptions between the functions as well as give a good jumping-off point for further module development.
I've updated various, grammar, spelling, and word consistency for each of the functions and feel like this is a good starting point for the modules about_help.
I can switch this to ready for review so it can be merged now or after #157.
@Celerium this is an impressive amount of work as @CalebAlbers noted. It seems it should be merged soon. @davidhaymond thoughts?
@Celerium this is an impressive amount of work as @CalebAlbers noted. It seems it should be merged soon. @davidhaymond thoughts?
@adrianwells thank you, something to note as it's been a while, so it would be a good idea to do a once-over of this addition as well as make sure any of the new functions include comment-based help.
@Celerium this is an impressive amount of work as @CalebAlbers noted. It seems it should be merged soon. @davidhaymond thoughts?
I would love to see this merged and included in v2.3.0. I'll see if I can find time this week to review it.
@Celerium This PR seems ready to me. Could you rebase your branch on top of the current master branch and squash all the commits? I'd like to try to keep the Git history relatively clean.
It looks like you've allowed maintainers to edit the PR, so if you like, I can rebase and merge for you.
@Celerium This PR seems ready to me. Could you rebase your branch on top of the current master branch and squash all the commits? I'd like to try to keep the Git history relatively clean.
It looks like you've allowed maintainers to edit the PR, so if you like, I can rebase and merge for you.
@davidhaymond, if you could that would be wonderful. Thank you
I've cleaned up this PR and merged into master! Thanks again for your incredible contribution, @Celerium!
Addresses issue #56
Quite a bit to go over with this initial update so ZERO rush to get this in place but overall 99% of the changes are the addition of comment-based help to all wrapper functions with support for the
Get-Help <command name> -online
function.Example:
Get-Help Get-ITGlueUsers -online
This will take you to https://api.itglue.com/developer/#accounts-users
I believe I have everything in a good initial state but with writing some much documentation it wouldn't surprise me if there are grammar or consistency issues between the wrappers. I have tested most of the functions after the modifications and I have not found any issues yet but I am only familiar with GET methods right now.
What are everyone's thoughts on the structure and or next steps?
Unless otherwise defined all modifications are additions of comment-based help
Pester Tests
APIKey
BaseURI
ModuleSettings
ConfigurationInterfaces
Configurations
ConfigurationStatues
ConfigurationTypes
Contacts
ContactTypes
FlexibleAssetFields
FlexibleAssetTypes
FlexibleAssets
Locations
Manufacturers
Models
Organizations
OrganizationStatuses
OrganizationTypes
PasswordCategories
Passwords
Users