itglue / powershellwrapper

This PowerShell module acts as a wrapper for the IT Glue API.
Apache License 2.0
120 stars 51 forks source link

Specify UTF-8 in API requests to support Unicode characters #162

Closed davidhaymond closed 1 year ago

davidhaymond commented 1 year ago

Closes #12, closes #97, closes #103.

adrianwells commented 1 year ago

@davidhaymond Thank you. Plan to merge this and then making it 2.3.0 release. Thoughts?

davidhaymond commented 1 year ago

@davidhaymond Thank you. Plan to merge this and then making it 2.3.0 release. Thoughts?

That sounds great. Would it be a good idea to wait for #152 and #163 to be merged as well? They may take a bit of time to resolve merge conflicts however, so perhaps we should release this important bugfix right away and then do a later release with further improvements.

oOblik commented 1 year ago

I certainly wouldn't mind resolving the conflicts in #163 if this is merged first.

adrianwells commented 1 year ago

@davidhaymond @oOblik Thank you. Will proceed to merge this and then #163 can be updated. Was thinking it'd be good to attempt an update sooner so if #152 is ready or will be soon, can wait and then add it to 2.3.0 release.