search

ithacaxyz / odyssey

A testnet open-source Layer 2 from the future, co-designed with the developer tools stack.
https://www.ithaca.xyz/updates/odyssey
Apache License 2.0
137 stars 28 forks source link

chore: Refactor fork handling and optimize revm_spec function #30

Closed malik672 closed 3 days ago

malik672 commented 3 days ago

I mean my idea is that forks won't decrease but increase and we will still have to support them, so instead of changing them later we can just optimize for them now

onbjerg commented 3 days ago

As mentioned in the issue I don't think this is the way to go, I appreciate your contribution nonetheless:)

Houseofkholin commented 3 days ago

Saw your

As mentioned in the issue I don't think this is the way to go, I appreciate your contribution nonetheless:)

Saw your other comment and I agree btw I wanted to propose to use an fxhashmap rather than tree in the first place tbh I didn’t just want to add anymore dependency, I just thought there should be a better way to handle it than the if/else performant wise(will still find it btw). I will probably find it and run some benchmark on it also, if I find a more efficient way can I include a benchmark in the code base ?

I’m still @malik672 just had to create this acc since I’m outside and don’t have access to my acc