search

ithacaxyz / odyssey

A testnet open-source Layer 2 from the future, co-designed with the developer tools stack.
https://www.ithaca.xyz/updates/odyssey
Apache License 2.0
200 stars 49 forks source link

Duplicated `secp256r1` precompiles code #42

Closed 0xurb closed 1 week ago

0xurb commented 1 month ago

Maybe enable feature on reth_revm crate forsecp256r1? Or it’s a some reason to re-write that on Odyssey?

mahmudsudo commented 3 weeks ago

can i take on this issue ?

mattsse commented 3 weeks ago

what code is duplicated?

mattsse commented 3 weeks ago

looks like the EIP-7212 secp256r1 Precompile indeed already exists in revm

mahmudsudo commented 3 weeks ago

can i take on this issue ?

mattsse commented 3 weeks ago

yes please @mahmudsudo

mattsse commented 3 weeks ago

@mahmudsudo we can take this directly from the revm dependency

mahmudsudo commented 3 weeks ago

just to be clear , should i eliminate the secp256rl in the precompile and replace its usage with the one from reth::revm::revm ?

mattsse commented 3 weeks ago

yes those should be equivalent