chore: useful reth / alloy type conversions

ithacaxyz / op-rs

Apache License 2.0

58 stars 6 forks source link

chore: useful reth / alloy type conversions #82

Open merklefruit opened 2 months ago

merklefruit commented 2 months ago

The following traits should be implemented in alloy to remove manual casting functions in op-rs:

impl From<reth::primitives::SealedBlock> for alloy::rpc::types::Block
impl From<reth::primitives::SealedHeader> for alloy::consensus::Header
impl From<reth::primitives::TransactionSigned> for Option<alloy::consensus::TxEnvelope> (TryFrom is fine too)
impl From<reth::rpc::types::Block> for alloy::rpc::types::Block<TxEnvelope>

GrapeBaBa commented 2 months ago

@merklefruit let me try

GrapeBaBa commented 2 months ago

@merklefruit When I looked [alloy](), it did't depend on reth-primitives and i thought it should not, so i am confused does this issue make sense?

merklefruit commented 2 months ago

Yeah that's the issue. We can just wait to see if Reth is interested in using Alloy types for this and then it will be possible. For now this is blocked - but would like to keep this open just to remember which type conversions we need eventually.