ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
113 stars 15 forks source link

Focusing on a heading nested under a link doesn't render a blue outline in Chrome #485

Open NazimHAli opened 1 year ago

NazimHAli commented 1 year ago

Expected behavior A blue outline on focus. Works correctly in Firefox:

Screen Shot 2023-01-27 at 5 52 00 PM

Actual behavior There's no blue outline on focus

Steps to reproduce the issue

Reproducible in Chrome, but not on Firefox:

  1. In Chrome, visit https://pharos.jstor.org/storybooks/wc/iframe.html?id=components-link--visited-link-heading&viewMode=story
  2. Press tab until it focuses on the link
  3. There's no blue outline on focus

Pharos version 12.17.0

Your environment

chrisjbrown commented 1 year ago

did some digging and came up empty 😅 same issue it seems in Safari.

I do see the correct styles being added to the #link-element when programmatically selecting it. but for whatever reason it's not shown 😕

NazimHAli commented 1 year ago

did some digging and came up empty 😅 same issue it seems in Safari.

I do see the correct styles being added to the #link-element when programmatically selecting it. but for whatever reason it's not shown 😕

I looked into it and found the issue to be not rendering the layout, so we just need to update the display. I will open a PR once I'm able to.

NazimHAli commented 1 year ago

Additional findings from research/experimentation for future reference:

daneah commented 1 year ago

We should consider how this is impacted as we think about using :focus-visible (#175)