ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

Tabs have gray grey horizontal scroll bar displayed even when the tab list cannot be scrolled #531

Open chrisjbrown opened 1 year ago

chrisjbrown commented 1 year ago

Expected behavior When the tab list can not be scrolled no scroll bar is shown

Actual behavior Scroll bar is always shown

Steps to reproduce the issue

  1. visit https://www.jstor.org/action/showAdvancedSearch or https://pharos.jstor.org/storybooks/wc/?path=/story/components-tabs--base
  2. see the grey bar below tab list

Screenshots or code Screenshot 2023-05-19 at 11 08 10 AM

Pharos version Indicate which version of Pharos you are using.

Your environment

Additional information Add any additional notes or further context about the issue here, including any known workarounds.

daneah commented 1 year ago

@chrisjbrown I see this, myself:

Screenshot 2023-05-19 at 11 22 01

Any chance this is due to e.g. an "always show scroll bar" system setting?

chrisjbrown commented 1 year ago

i don't believe so. Nazim and Florence also see the same as me. chrome and firefox

daneah commented 1 year ago

@chrisjbrown I can reproduce this by toggling this macOS system setting (under Appearance) between "When scrolling" and "Always."

Screenshot 2023-05-19 at 11 44 56
chrisjbrown commented 1 year ago

@chrisjbrown I can reproduce this by toggling this macOS system setting (under Appearance) between "When scrolling" and "Always."

Screenshot 2023-05-19 at 11 44 56

The default setting here is "automatic..." and if no mouse is connected the scrollbar doesn't show but if one is connected the scrollbar always shows. going to close for now as even if this is an issue it's very specific

chrisjbrown commented 1 year ago

Always show scroll bar advanced search text Advanced serach image

Not sure this changes the outcome but wanted to add the info here. as windows is also having this issue event with "always show scrollbars off"

brentswisher commented 2 weeks ago

Had a followup request for this from @bciaglo-ithaka in slack, reopening so we can take another look at options