ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
119 stars 15 forks source link

Table: fix the empty table column cell element and add test #726

Closed sirrah-tam closed 6 months ago

sirrah-tam commented 6 months ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? Resolves #724

Adds test to confirm that table that has an empty column header adds an empty table cell.

How does this change work? Updates the <tb></tb> to <td></td>

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: db1b2a04aef7476604b5d95fb94a8f271c13da45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 63.74 KB (-0.15% 🔽)