ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
119 stars 15 forks source link

Use @lit/react to build React components instead of doing it manually ourselves #728

Closed daneah closed 1 month ago

daneah commented 6 months ago

The problem Managing the React components is a maintenance burden and prone to error. Doing this ourselves incurs a whole area of work around duplicating component stories for React and building a composed Storybook, all of which add complexity and get in the way often.

The solution

daneah commented 6 months ago

custom-element-react-wrappers is another alternative if it proves useful/necessary

Niznikr commented 5 months ago

Something to note: https://react.dev/blog/2024/04/25/react-19#support-for-custom-elements

daneah commented 5 months ago

I saw that as well and shared around internally @Niznikr, exciting development! Thanks for sharing 😄

daneah commented 1 month ago

Closing this as an unlikely area of investment going forward; we will likely divest from React wrappers instead as teams eventually move up to React 19.