ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
119 stars 15 forks source link

Toaster: Add test for deleting an updateable toast #729

Closed ymouzakis closed 6 months ago

ymouzakis commented 6 months ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? This PR adds a unit test that verifies an updatable toast can be deleted and removed from the dom.

How does this change work? Create a toast, update it, try to delete it and verify to toaster has no toast.

Additional context This test covers the bug discovered through other means of testing that was reported and corrected in #720

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: fd162402fb547e16da265cfb446eac1955fe5c64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.35 KB (0%)