ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
112 stars 15 forks source link

fix(eslint): update linting ignore patterns #754

Closed daneah closed 1 month ago

daneah commented 1 month ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? ESLint was finding built files, when they existed, and not ignoring them. This issue was two-fold:

  1. The patterns weren't right per ESLint's new expectation for relative and recursive patterns, so the files would be considered if present
  2. The ignores were only configured in our main config, such that other plugins and so on would not use the list of ignores

How does this change work? Updating the patterns and putting them in their own object at the start of the final config returns us to a fast, passing lint even in the presence of built files.

Additional context Follows up #753

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 6798334baaf4d78549c73d839bb09cc0819c45cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.56 KB (0%)