ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
119 stars 15 forks source link

Tabs: Regression in scrolling behavior when updating to version 14 #760

Closed michael-iden closed 4 months ago

michael-iden commented 4 months ago

Expected behavior Contents of pharos tabs would scroll while tabs would remain fixed at the top of the page

Actual behavior Contents were unable to scroll at all given surrounding CSS

Steps to reproduce the issue

  1. Use pharos < 14 and generate a layout where tab panel scrolls
  2. Update to pharos 14
  3. See that the tab panel stops scrolling and the contents are all fixed on the page

Screenshots or code Here is a video showing the current behavior in prod when using pharos < 14 and then making the CSS change manually that was done in Pharos14. After making the change I attempt to scroll but its not handled https://github.com/ithaka/pharos/assets/13315416/9ed17f5f-c51c-4b61-985f-d01984206ff6

Pharos version 14.2.1

Your environment

Additional information This looks to have been in introduced by this change in pharos 14 https://github.com/ithaka/pharos/pull/690