ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
112 stars 15 forks source link

fix(tabs): allow scrolling the panel contents #761

Closed michael-iden closed 1 month ago

michael-iden commented 1 month ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? This allows the tabs panel contents to scroll if there is a height defined on the parent element in the DOM

How does this change work? Give the height: 100% so the browser can compute overflow behavior where applicable

Here is a video where I apply the fix to a few different contexts we use tabs to show it fixes the old behavior we had in pharos 13 without affecting the new behavior we added in pharos 14 release https://github.com/ithaka/pharos/assets/13315416/acb679a9-6d06-4c53-a49c-78576c69788a

Additional context Closes #760

changeset-bot[bot] commented 1 month ago

šŸ¦‹ Changeset detected

Latest commit: d60bf9705ce1b10194a47134a7958c3e10c0a5bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report šŸ“¦

Path Size
packages/pharos/lib/index.js 64.48 KB (-0.03% šŸ”½)