Card: Improve accessibility by moving overlay slot outside of <a> tag

[ymouzakis]

This change: (check at least one)

• [ ] Adds a new feature
• [x] Fixes a bug
• [ ] Improves maintainability
• [ ] Improves documentation
• [ ] Is a release activity

Is this a breaking change? (check one)

• [ ] Yes
• [x] No

Is the: (complete all)

• [x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
• [x] Test suite(s) passing?
• [x] Code coverage maximal?
• [x] Changeset added?
• [x] Component status page up to date?

What does this change address? Fixes a problem where the button inside of the overlay slot would not be picked up by the browser when tabbing through clickable elements. I believe this is because the button within the overlay was slotted inside of an anchor tag

How does this change work? Move overlay slot outside of the link tag

Additional context Add any other context here.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: f5b49e3439aa05d0832eda8e275c05fef5be4996

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

size-limit report 📦

Path	Size
packages/pharos/lib/index.js	64.44 KB (-0.06% 🔽)

[daneah]

@ymouzakis can you please update the PR description? Some information is missing and it seems like your commit message may have been truncated at the top there.