search

ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

Icon: Add "Save & Close" icon #788

Closed nkamau closed 4 months ago

nkamau commented 4 months ago

What is the use case for the component you're requesting? Based on conversations with metadata librarians, this button is necessary for batch editing as opposed to regular save being best for individual. It makes their lives much, much easier.

Icon:

Save Close

Where it's located:

Screenshot 2024-07-23 at 2 34 32 PM

Additional considerations Alt-text: Save & close

daneah commented 4 months ago

@nkamau In dark mode in my browser I can see that you have some non-transparent fill:

Screenshot 2024-07-23 at 20 52 51

Is this how this should be?

nkamau commented 4 months ago

@daneah At that moment, yes, but I had a meeting this morning and was about to update it. I'm going to close this for a fresh ticket.