ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

Upgrade to Lit 3 and latest scoped element packages #791

Closed daneah closed 2 months ago

daneah commented 4 months ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address?

How does this change work?

Additional context

This upgrade altered two things, as exposed by the unit tests:

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 77c63fd03a0168711940b5785523f8fe06b15979

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 63.95 KB (-1.08% 🔽)
daneah commented 4 months ago

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.

sirrah-tam commented 4 months ago

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.

Oop, yep you are correct, there is some weirdness with how things are rendered in Storybook right now. Probs shouldn't have approved that 🙃 Screenshot 2024-07-25 at 11 33 06 AM

daneah commented 3 months ago

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly.

@Niznikr any chance you've run into this? I'm about at wit's end trying different things here 😓

Niznikr commented 3 months ago

It might be an issue with Storybook as the issue reporter also seems to be using Lit 3 and the symptoms seem similar. https://github.com/storybookjs/storybook/issues/28634

daneah commented 3 months ago

@Niznikr thanks for the link—had been looking around a bit in their issues but missed that one. It's a slightly different manifestation, but agreed that it might reveal a deeper issue. Will keep picking at it a bit, and maybe file a separate issue. Probably good to try a very small repro from scratch using the latest Lit and Storybook I suppose 😄