chore(sass): address deprecation warnings for nested rules

ithaka / pharos

JSTOR's design system

https://pharos.jstor.org

MIT License

123 stars 16 forks source link

chore(sass): address deprecation warnings for nested rules #800

Closed daneah closed 3 months ago

daneah commented 3 months ago

This change: (check at least one)

[ ] Adds a new feature
[ ] Fixes a bug
[x] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[ ] Changeset added?
[ ] Component status page up to date?

What does this change address?

Resolves #783

How does this change work? Move declarations above nested rules

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 16b8572078f17f2b98ba45f75759754c93b4e550

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path	Size
packages/pharos/lib/index.js	65.89 KB (+0.14% 🔺)

daneah commented 3 months ago

Currently this attempt is causing styling issues, and trying the other approach of nesting things within & { } causes stylelint to conflict and fail. Revisiting later.