ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

Update the table caption warning to recommend correct attribute to visually hide the caption #801

Closed brentswisher closed 2 months ago

brentswisher commented 2 months ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? If you don't provide a table caption, there is an error thrown with directions how to fix it:

Table must have an accessible name. Please provide a caption for the table using the caption attribute. You can hide the caption visually by setting the hide-caption-visually property.

However, the correct property to visually hide it is actually just hide-caption not hide-caption-visually

How does this change work? Updates the error message to include the correct property in the error message

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 17900dd83f9ce817be3f19917637d4724bc7c85d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 65.88 KB (+0.02% 🔺)