ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

Switch: New component contribution #825

Closed michael-iden closed 3 weeks ago

michael-iden commented 4 weeks ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address? Closes #821 by creating a new toggle switch component

How does this change work? Adds a stylized variant of a checkbox to indicate an enabled/disabled state and a mechanisms to update the state

Additional context

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 19ebdfaccebc936df6f8fb60068f5e56c996a074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------- | ----- | | @ithaka/pharos-site | Minor | | @ithaka/pharos | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 weeks ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 66.69 KB (+0.66% 🔺)
brentswisher commented 3 weeks ago

🤔 Running pharos site locally, I am not seeing the component render in the examples. but I am seeing the label.

Screenshot 2024-10-30 at 8 33 40 AM
brentswisher commented 3 weeks ago

🤔 Running pharos site locally, I am not seeing the component render in the examples. but I am seeing the label.

Ah, never mind, the site just needs the new component added where it is initializing Pharos components, I can push a fix for that