ithaka / pharos

JSTOR's design system
https://pharos.jstor.org
MIT License
123 stars 16 forks source link

fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 #827

Closed michael-iden closed 7 hours ago

michael-iden commented 3 weeks ago

This change: (check at least one)

Is this a breaking change? (check one)

Is the: (complete all)

What does this change address?

826

How does this change work? Remove overflow property for an element that will never overflow

Additional context

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 1f3751b67c530acc4f3c42916d5864b2851a0ee9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @ithaka/pharos | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

size-limit report 📦

Path Size
packages/pharos/lib/index.js 66.32 KB (-0.03% 🔽)
brentswisher commented 1 day ago

I see the size report action is failing, wondering if that is because of the node 22 update?

michael-iden commented 1 day ago

@brentswisher I also noticed the size job failing and it does relate to node 22 but I don't know how to fix it. It might be a task that relies the latest build.

My interpretation of the error is that the job runs a build against both the current branch and develop with node22, and its failing to run against develop because it has the unsupported node 20 syntax. So it should get corrected once we merge and develop gets these updates to evaluate in the next PR