search

itinero / reminiscence

A library for cross-platform memory mapping.
MIT License
9 stars 6 forks source link

Update for VS2017. #8

Closed airbreather closed 7 years ago

airbreather commented 7 years ago

Fixes #7

NOTE 1: There are some commits on master that haven't yet been merged to develop yet, so you might want to do those first before grabbing this, otherwise you'll probably get a weird merge commit.

NOTE 2: I wasn't able to get Profile259 working. Itinero proper doesn't target Profile259, so I don't think it's important here... am I wrong? If so, it seems like Profile259 is a subset of .NETStandard 1.0, so if we wanted to support those targets, couldn't we just downgrade the .NETStandard version we target from 1.3 to 1.0 and call it a day? Or would users have to put up with that annoying NETStandard.Library garbage when they try to use it, and therefore this would be off-putting?

airbreather commented 7 years ago

Interesting, apparently since my branch was building off of master, merging this PR into develop would automatically merge the other two along with it.

airbreather commented 7 years ago

Looks like this was done independently in d308506 instead.