Features/convexhull - Githubissues

pietervdvn commented 6 years ago

The convex hull code, including updates and removals

pietervdvn commented 6 years ago

Yep, I just figured that out too...

Seems to have gotten lost here: https://github.com/itinero/routing/commit/3b513096aa19f1342608b45743904409f3413618#diff-edcb579d380dc1929cd182d8e94c24b0

Met vriendelijke groeten, Pieter Vander Vennet

2018-05-25 16:32 GMT+02:00 Ben Abelshausen notifications@github.com:

@xivk commented on this pull request.

In src/Itinero/Algorithms/Default/ConvexHull.cs https://github.com/itinero/routing/pull/187#discussion_r190912914:

return hullBreach ? Quickhull(allPoints) : hull;

}

///

/// Checks if newPoint is contained within the hull.

/// If not, the element is added to the hull-list, at the appropriate position to maintain a with-the-clock order.

/// (If inOrder is disabled, the point is just appended as last element)

/// The point of insertion is returned

///

///

///

///

///

public static int UpdateHull(List hull, Coordinate newPoint, bool inOrder = true)

{

if (PointInPolygon.PointLiesWithin(

The file PointInPolygon was deleted in the develop branch, it was lost in the merge with develop.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/itinero/routing/pull/187#discussion_r190912914, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZgbrUN_n19yJKd8xAouyIb2LkbmNveks5t2BXjgaJpZM4UKrhP .

xivk commented 6 years ago

I'm merging this now to match what was changed last time for point in polygon.

xivk commented 6 years ago

I reorganized things to match the way things are structured right now. Everything lives in the Itinero.LocalGeo namespace now not in Itinero.Algorithms. I made things internal not exposing things publicly making it easier to change things later. I also improved the hull by adding the first point again at the end closing the ring.

My commits are here:

https://github.com/itinero/routing/tree/pietervdvn-features/convexhull

I would be good if we could continue the work there. I found an issue by writing a test with real data:

itinero / routing

Features/convexhull #187

@xivk commented on this pull request.