itinero / routing

The routing core of itinero.
Apache License 2.0
220 stars 70 forks source link

Bug in ShapefileReaderExtensions #368

Open TomQv opened 7 months ago

TomQv commented 7 months ago

Itinero.IO.Shape.Reader.ShapefileReaderExtensions: Bug AddToAttributeCollection(this ShapefileDataReader reader, IAttributeCollection collection) at line 49:

public static void AddToAttributeCollection(this ShapefileDataReader reader, IAttributeCollection collection)
{
    var valueString = string.Empty;
    for (var i = 1; i < reader.FieldCount; i++)
    {
        var name = reader.GetName(i);
        // 5.12.23, Tom, bug
        //var value = reader.GetValue(i - 1);
        var value = reader.GetValue(i);
        valueString = string.Empty;
        if (value != null)
        {
            valueString = value.ToInvariantString();
        }
        collection.AddOrReplace(name, valueString);
    }
}