search

itinero / routing

The routing core of itinero.
Apache License 2.0
222 stars 71 forks source link

ShapeFileReader Exception Never Gets Thrown #86

Closed airbreather closed 7 years ago

airbreather commented 7 years ago

I was playing around with a vehicle profile for MultiNet, and in my first go, I had chosen a combination of profile attributes that I clearly shouldn't have, because this exception got thrown. It took me a while to figure out what was going on.

When I did figure this out, I came to this block with its nicer message... it would have saved me about a half hour or so if that exception had been thrown, but since the check does > instead of >=, it never got hit.

Would it be correct to change that > to >= in ShapeFileReader's version of this exception?

(edit: just a typo fix)

xivk commented 7 years ago

That looks like an easy enough fix, will try to do this tomorrow.

Thanks for reporting!

xivk commented 7 years ago

Took me a bit longer but, fixed now!

Thanks again!