search

itinycheng / flink-connector-clickhouse

Flink SQL connector for ClickHouse. Support ClickHouseCatalog and read/write primary data, maps, arrays to clickhouse.
Apache License 2.0
349 stars 149 forks source link

why ClickHouseBatchExecutor#addToBatch() deal with UPDATE_AFTER ? #2

Closed liyubin117 closed 2 years ago

liyubin117 commented 2 years ago

in my opinion, ClickHouseBatchExecutor is used in append-only scenario, but in fact, it also deal with update event

itinycheng commented 2 years ago

in my opinion, ClickHouseBatchExecutor is used in append-only scenario, but in fact, it also deal with update event

Yes, you are right. ClickHouseBatchExecutor is only used in the append-only scenario. In the current code, the update event won't enter ClickHouseBatchExecutor.addToBatch; the code will run normally. The current code causes misunderstanding; I will fix it.