search

itisnajim / SocketIOUnity

A Wrapper for socket.io-client-csharp to work with Unity.
MIT License
393 stars 67 forks source link

Fix issue where Newtonsoft conflicts with default packages. #18

Closed Spillmaker closed 1 year ago

Spillmaker commented 2 years ago

Not sure when Unity started doing it, but in my use-case (2D project, Unity 2021.3.4f1 on Mac) there is already a Newtonsoft package included as an dependency for the 2D base package. Making it impossible to use this package since you cant have multiple DLL-files with the same package name.

I removed the DLL-files and included Newtonsoft as a dependency.

Initial testing for my usecases seems to work fine, but since i dont know this codebase i cant be 100% sure that this will work in all scenarios.

itisnajim commented 2 years ago

Maybe i have to put all possible libraries to package.json dependencies property instead, what you provide "nuget.newtonsoft-json" : "3.0.2" is a one

Spillmaker commented 2 years ago

Think that would be beneficial yea, but some libraries may not be available, so you would have to check that first.

This is a good start on that progress tho.

didix16 commented 1 year ago

Any news about merging PR? Thanks

OlliePugh commented 1 year ago

Would be great to see this get merged, worked perfectly for me 👍

sumitprof2017 commented 1 year ago

i have multiple assemblies problem with json.net how can i fix this please help?