search

itisnajim / SocketIOUnity

A Wrapper for socket.io-client-csharp to work with Unity.
MIT License
393 stars 67 forks source link

fix: Disabled auto reference on precompiled assemblies in order to no… #37

Closed atteneder closed 1 year ago

atteneder commented 1 year ago

…t interfere with user projects.

While trying to figure out the root of an issue in the glTFast Unity package, I found out that the precompiled assemblies you're using in this package are auto-referenced and somehow overrule parts of the .NET API, leaving my package behind with compiler errors.

The assemblies are now referenced directly.

Disclaimer: I only got rid of compiler errors in glTFast. I did NOT test if SocketIOUnity still works as intended. I'll leave that up to the package maintainers.

thanks.

atteneder commented 1 year ago

Another observation: Not all of the precompiled assemblies seem to be used!?

itisnajim commented 1 year ago

Another observation: Not all of the precompiled assemblies seem to be used!?

from the original package https://www.nuget.org/packages/SocketIOClient/3.0.6#dependencies-body-tab depends on: System.Collections (>= 4.3.0) System.Reactive (>= 5.0.0) System.Text.Json (>= 6.0.2)

and maybe these depends on other libs too,
i can't find time to check everything, your PR is appreciated, thanks 🤗