search

itk-dev-rpa / OpenOrchestrator

MIT License
1 stars 4 forks source link

Add QueueStatus.ABANDONED #78

Closed hbpe-aarhus closed 6 months ago

hbpe-aarhus commented 6 months ago

Implementation of https://github.com/itk-dev-rpa/OpenOrchestrator/issues/77

In addition to adding a new Abandoned state for queue items, I also let the function "set_queue_element_status" update the end_date of a queue item if its state is Abandoned.

ghbm-itk commented 6 months ago

Well done! Remember to update the changelog :)

Should the end time be noted when a queue element is marked as abandoned? It's technically not ended when it's abandoned?

hbpe-aarhus commented 6 months ago

Cheers!

Yes, I was on the fence about setting the end date as well. On the one hand, setting the end date lets the user see when the queue item was actually flagged as being abandoned. On the other hand, the queue item was never actually finished.

ghbm-itk commented 6 months ago

I guess one could argue that more information is better than no information. It's just something one needs to be aware of. Lets keep it as you made it.