itkach / aard2-android

Aard2 for Android, a simple dictionary app
GNU General Public License v3.0
426 stars 98 forks source link

Remove bookmark/history size limit #111

Open niktss opened 3 years ago

niktss commented 3 years ago

It's just a text file I'm assuming - even a full book is just megabytes, so storage isn't a concern.

soshial commented 1 year ago

I am also very interested in unlimited bookmark/history? Why any limitations?

itkach commented 1 year ago

storage is not a concern, but lookup and update speed, as well as filtering and sorting in ui are. Perhaps current limit of a hundred items is conservative and could be higher, but to remove it entirely requires a more sophisticated storage implementation.

ildar commented 10 months ago

I like Aard very much and use it since aard1 times. But this limitation spoils the whole idea of using it as a dictionary app (I guess that wiki-type users do not care) Losing data disappoints me a lot. In this case the words I learn & bookmark. Would you please raise the limit as a 1st step? E.g. 1000 looks like a good compromise.

ildar commented 10 months ago

Silent discading of data is most upsetting.

niktss commented 10 months ago

I like Aard very much and use it since aard1 times. But this limitation spoils the whole idea of using it as a dictionary app (I guess that wiki-type users do not care) Losing data disappoints me a lot. In this case the words I learn & bookmark. Would you please raise the limit as a 1st step? E.g. 1000 looks like a good compromise.

There already is a Material UI fork with 1000 as limit; the name escapes me however. The icon was cat themed or something.

ildar commented 10 months ago

yes, found it: https://github.com/brainail/.everboxing/commit/b61f8142f34734735d26d1fdb498d85787bb545e But even 1000 bookmarks may be too low:

ildar commented 10 months ago

Screenshot_20230820-120149_Duolingo

ildar commented 8 months ago

@itkach , can we have a (hidden) option for this? maybe in the shared_prefs/app.xml