search

itkach / aard2-android

Aard2 for Android, a simple dictionary app
GNU General Public License v3.0
426 stars 98 forks source link

text part in the black theme is not visible #130

Closed OmlineEditor closed 2 years ago

OmlineEditor commented 2 years ago

the default text part in the black theme is not visible. if you select the text then the text is visible

1

itkach commented 2 years ago

Looks like this CSS rule in monobook theme is the culprit - color is explicitly set to black, not sure why. Older versions of russian wikipedia did not use abbr for dates (I have one from 2018) so the issue does not manifest itself there.

itkach commented 2 years ago

Fixed in https://github.com/itkach/mwscrape2slob/commit/5305cd52cdb2a3fb6164fddd3066541deddae7ca

For existing dictionaries, load night.css as user style.

OmlineEditor commented 2 years ago

the problem is not solved. I reinstalled the application on a new device and the problem remained, you did not make changes to the main program on f-droid. please fix the problem

itkach commented 2 years ago

The issue is not with the application, it is with dictionary CSS and inline styles in articles, and thus cannot be resolve by reinstalling the app. It can only be resolved by

a) getting a new dictionary file compiled with updated version of https://github.com/itkach/mw2slob/, such as this May 2022 ruwiki

b) overriding css with user style, as already mentioned.

did not make changes to the main program on f-droid

I do not publish to F-Droid and the version published there is not built or packaged by me, so use at your own risk and address F-Droid related issues to https://f-droid.org/en/issues/

OmlineEditor commented 2 years ago

the program has its own built-in style. you can change it in case there are problems in other dictionaries and you don't need to use a custom style.