itkach / aard2-android

Aard2 for Android, a simple dictionary app
GNU General Public License v3.0
425 stars 98 forks source link

bookmarks may be broken when upgrading dictionnary files #136

Open d-faure opened 2 years ago

d-faure commented 2 years ago

When installing new versions of dictionary files, some bookmarks may be unable to reach their (new) location.

Whereas this may be obvious that reworked articles from a release to another one should be difficult/impossible to be reachable using old bookmarks, there isn't any convenient mean to start a new search from the old bookmark title.

This is the kind of tiny quality of life improvement that the application could benefit

itkach commented 2 years ago

Bookmarks do not record dictionary file location. Dictionary in a bookmark is identified by uri tag, so that bookmark continues to work even if specific dictionary (e.g. English Wikipedia) is updated to a new version (assuming new version still contains article with the bookmarked title). Sounds like this is mostly a theoretical concern. Am I missing something?

francwalter commented 2 years ago

Indeed I made the same experience: after each update of German wiki most of bookmarks are broken.

It is very unlikely that the links changed, though I didn't scrutinize that. How, anyway? I would need to compile the app and debug in Android studio, I guess.

I searched then the few important ones again manually and bookmarked them again. Leading to the conclusion that there are fewer and fewer really important bookmarks ;)

It's not too important to me anymore, anyway :) Thanks!