search

itkach / aard2-android

Aard2 for Android, a simple dictionary app
GNU General Public License v3.0
425 stars 98 forks source link

Symbols in search text are ignored #140

Closed sjl872964789 closed 2 years ago

sjl872964789 commented 2 years ago

Describe the bug Symbols in search text are ignored

To Reproduce

  1. Open the app
  2. Favorite any word that contains a symbol (eg . - ' ~)
  3. Click on the Favorites list
  4. Search for the word
  5. Many words that do not contain this character will also be searched

Expected behavior When searching should also search for symbols

Screenshots https://user-images.githubusercontent.com/15941953/161544689-ae102143-d609-4713-83c0-0c67e8f63e74.mp4

Smartphone (please complete the following information):

itkach commented 2 years ago

This mode of matching - ignoring punctuation-like symbols - makes some searches easier, for example something like L'Ardève can be found by typing just la. But it does put titles containing punctuation at a disadvantage and is overall somewhat unintuitive. I'll change it.

ildar commented 2 years ago

Does this mean that search becomes strict to umlauts and diacritics ? If so can this be optional? Thanks

itkach commented 2 years ago

It does not. This is about filtering bookmarks/history and only changes treatment of punctuation-like symbols.

On Mon, Apr 18, 2022, 02:24 ildar @.***> wrote:

Does this mean that search becomes strict to umlauts and diacritics ? If so can this be optional? Thanks

— Reply to this email directly, view it on GitHub https://github.com/itkach/aard2-android/issues/140#issuecomment-1101137077, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABME4P3YDSIQ7W4NYMXULTVFT5YPANCNFSM5SPMKYQQ . You are receiving this because you modified the open/close state.Message ID: @.***>