search

itkach / aard2-android

Aard2 for Android, a simple dictionary app
GNU General Public License v3.0
458 stars 97 forks source link

Cosmetic issue (clipped icons) with release 0.41 #93

Closed jcp-sd closed 5 years ago

jcp-sd commented 5 years ago

I noticed that many of the icons in UI became clipped / truncated right after upgrading to release 0.41 (installed and upgraded through the Play Store). I have used Aard2 for quite awhile and just recently before upgrading from 0.40 to 0.41 and never noticed this before.

Eveything else seems to function just fine for me in release 0.41

Great app, and searches are fast for such a small, brain damaged device!

Device: Moto-G4 phone OS: Android 7.0 (April 1, 2018 security patches) Display: 1920 x 1080

Screenshot_20190617-150818

itkach commented 5 years ago

I had to upgrade Android support dependencies and switch to a different icon font library that works with Android's current resource compiler. Didn't see any clipping issues on my devices. Will need to investigate, thanks for the report.

MHBraun commented 5 years ago

Can not confirm the icon cutting on

LG V20 H990DS with Android 8.0.0

On 6/17/19 9:32 PM, itkach wrote:

I had to upgrade Android support dependencies and switch to a different icon font library that works with Android's current resource compiler. Didn't see any clipping issues on my devices. Will need to investigate, thanks for the report.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/itkach/aard2-android/issues/93?email_source=notifications&email_token=AAYE2S25B75UJ3V3MVJFFJDP3BCKJA5CNFSM4HY2YMN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX47P7I#issuecomment-502921213, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYE2SYLOM76PDBZBWTF5QLP3BCKJANCNFSM4HY2YMNQ.

jcp-sd commented 5 years ago

It does not seem to be an issue, problem on other devices.

I have the latest release of Aard2 insalled on a tablet device, and no problems there.

No worries, sounds like it could be tricky to isolate the problem.

CaptainFrosty commented 5 years ago

I also have this issue, on an Samsung SM-G55U running stock Nougat

happens in landscape as well Untitled

itkach commented 5 years ago

@jcp-sd @CaptainFrosty try https://github.com/itkach/aard2-android/releases/tag/0.43, looks like this was fixed in the font icon library, but I was using an older version...

jcp-sd commented 5 years ago

I just upgraded to release 0.43 (the f-droid build) and everything looks OK with the icon issue.

Thank you itkach !

CaptainFrosty commented 5 years ago

this is fixed and can be closed