search

itm / testbed-runtime

WISEBED Wireless Sensor Network Testbed Infrastructure Software
https://github.com/itm/testbed-runtime/wiki
15 stars 11 forks source link

SNAACertificate implementation #304

Closed pierre128 closed 11 years ago

pierre128 commented 11 years ago

Here is a pull request for SNAACertificate implementation, also including a client library and an organization service implementation.

At the higher level, we have added "client-certificate" and "organization-service" folders. In the "snaa" folrder, we have added a package called "eu.smartsantander.cea.certificate".

In the "snaa" folder, we have added a "certs" subfolder, giving examples for using organization certificates.

danbim commented 11 years ago

Hi Pierre & Kim!

Thanks a million for sending that pull request. I've just one thing to ask you for: could you modify it in such a way that I can pull it into a feature branch (e.g. feature/snaa-certificate) instead of develop? This way, I can have a look at it before merging it directly into the development branch.

Cheers, Daniel

master-lincoln commented 11 years ago

You can test pull requests locally by pulling them manually: https://gist.github.com/piscisaureus/3342247

danbim commented 11 years ago

Thanks for the tip @master-lincoln!! However, I would prefer to put it in a public (=non-local) branch for testing by more people than me before merging in develop.

pierre128 commented 11 years ago

Hi Daniel. Yes we are going to do that. Note that is may take 2 or 3 days as we are out of office this week. Best regards,

Pierre

De : Daniel Bimschas [notifications@github.com] Date d'envoi : lundi 12 août 2013 10:06 À : itm/testbed-runtime Cc: ROUX Pierre Objet : Re: [testbed-runtime] SNAACertificate implementation (#304)

Hi Pierre & Kim!

Thanks a million for sending that pull request. I've just one thing to ask you for: could you modify it in such a way that I can pull it into a feature branch (e.g. feature/snaa-certificate) instead of develop? This way, I can have a look at it before merging it directly into the development branch.

Cheers, Daniel

— Reply to this email directly or view it on GitHubhttps://github.com/itm/testbed-runtime/pull/304#issuecomment-22478336.

danbim commented 11 years ago

No problem, that's fine! I'll be out of office this week, too, so merging will probably happen next week whatsoever.

master-lincoln commented 11 years ago

You could checkout their changes and push it to a public branch yourself: git fetch origin pull/304/head:feature/snaa-certificate git checkout feature/snaa-certificate git push origin/feature/snaa-certificate feature/snaa-certificate

(untested)

sebers commented 11 years ago

Since this is a kind of duplicate for #313, I will close this.