search

itm / testbed-runtime

WISEBED Wireless Sensor Network Testbed Infrastructure Software
https://github.com/itm/testbed-runtime/wiki
15 stars 11 forks source link

Adding new branch feature/snaa-certificate #313

Closed pierre128 closed 11 years ago

pierre128 commented 11 years ago

Here is the pull request for SNAACertificate implementation, also including a client library and an organization service implementation. It added a new independent feature branch named "feature/snaa-certificate" instead of modifying the code base in the branch develop.

The client library and organization service can be found at: /client-certificate and /organization-service. In the "snaa" folrder, we have added a package called "eu.smartsantander.cea.certificate". We have also added an installation document in /organization-service/src/main/resources explaining our SNAA implementation.

sebers commented 11 years ago

The following dependency cannot be resolved:

    <dependency>
        <groupId>fr.cea.util</groupId>
        <artifactId>com.snaa.certificate.util</artifactId>
        <version>1.0-SNAPSHOT</version>
    </dependency>
pierre128 commented 11 years ago

Sebers, are you sure that you have the last version of this pull request? The name "com.snaa.certificate.util" is the old package name of the "client-certificate" and I have changed it for a long time ago. Where did you find the dependency above? I verified all 3 pom files that I have modified and I'm sure that this dependency doesn't exist. These 3 pom file are: /client-certificate/pom.xml; /organization-service/pom.xml; /snaa/pom.xml

sebers commented 11 years ago

I found it in snaa/pom.xml but it was obviously a merge conflict that I did not resolve properly. The new dependency is

            <dependency>
                <groupId>fr.cea.util</groupId>
                <artifactId>client-certificate</artifactId>
                <version>1.0-SNAPSHOT</version>
            </dependency>

However, it is still unknown since client-certificate and organization-service are not introduded as modules in tr.

I will fix it and adapt the naming and structure to the common tr style if you do not mind.

Is is OK to you?

nguyenki commented 11 years ago

Sebers, We have discussed about your suggestion. Just feel free to change the naming and structure as you need. I didn't add the 2 modules in the tr. because I think that they should be tested before being presented in the pom file.

sebers commented 11 years ago

Hi Nguyenki, thanks a lot and no problem about not adding them as modules - it is fine for me.

sebers commented 11 years ago

"Moved" to new feature branch in this repository: https://github.com/itm/testbed-runtime/tree/feature/snaa-certificate